Review Request 117784: Remove duplicated ConfigLoader

[Marco Martin]

> On April 26, 2014, 1:49 p.m., Marco Martin wrote:
> > did you try a service? here for instance the mpris dataengine doesn't work anymore, i can't send commands like pause/play
> 
> Martin Klapetek wrote:
>     Speaking with the mpris applet maintainer hat - as it was committed, this^ is not a problem anymore I take?

it works correctly now, the problem was fixed prior pushing


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117784/#review56623
-----------------------------------------------------------


On April 26, 2014, 3:09 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117784/
> -----------------------------------------------------------
> 
> (Updated April 26, 2014, 3:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Remove duplicated ConfigLoaderin Plasma.
> 
> This moved to KConfigGui as KConfigLoader.
> 
> Use of private KConfig API in Service had to be ported to use only
> public method.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 8501228 
>   autotests/configloadertest.h 791b0f6 
>   autotests/configloadertest.cpp a89d951 
>   autotests/configloadertest.xml 13ccd32 
>   src/plasma/CMakeLists.txt a7e9892 
>   src/plasma/applet.h 06147fb 
>   src/plasma/applet.cpp 88c4973 
>   src/plasma/configloader.h 4ef9cb4 
>   src/plasma/configloader.cpp 4822548 
>   src/plasma/containment.cpp 95c9da0 
>   src/plasma/dataengine.cpp 86e33d1 
>   src/plasma/private/applet_p.h f31f02e 
>   src/plasma/private/applet_p.cpp d0ac89e 
>   src/plasma/private/configloader_p.h 25bb6b8 
>   src/plasma/private/configloaderhandler_p.h df96a33 
>   src/plasma/private/service_p.h 3a70392 
>   src/plasma/service.cpp 1b3cbaf 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp f36270c 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.h bd70aa3 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a3a9b51 
> 
> Diff: https://git.reviewboard.kde.org/r/117784/diff/
> 
> 
> Testing
> -------
> 
> Ran plasma shell as before.
> plasmaengineexplorer service seems to lists entries correctly.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140427/ec505047/attachment.html>