Review Request 117801: Make PMC MPRIS compatible

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117801/#review56684
-----------------------------------------------------------



libs/mediacenter/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117801/#comment39531>

    maybe keep mpris2 inside mediacenter/ ?



libs/mpris2/mediaplayer2.cpp
<https://git.reviewboard.kde.org/r/117801/#comment39532>

    Instead of keeping a copy of the mainwindow, use a signal emitted from MediaPlayer2 and handle this in a MainWindow slot (you'll need to relay it through Mpris2).
    Its always a good idea to keep dependencies at the minimum.



libs/mpris2/mediaplayer2player.cpp
<https://git.reviewboard.kde.org/r/117801/#comment39535>

    return mediaPlayerPresent() works fine for me



libs/mpris2/mediaplayer2player.cpp
<https://git.reviewboard.kde.org/r/117801/#comment39533>

    Move this into a common function so that it can be reused at other places.



libs/mpris2/mediaplayer2player.cpp
<https://git.reviewboard.kde.org/r/117801/#comment39534>

    if (media) {
    
    If you use KDevelop,  goto Configure KDevelop > Source formatter and choose KDElibs. Then you can use "Format files" on your code to auto format it.
    Otherwise you can use astyle.


- Shantanu Tushar


On April 27, 2014, 2:33 p.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117801/
> -----------------------------------------------------------
> 
> (Updated April 27, 2014, 2:33 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Add Dbus adaptors through which any other application can programmatically control PMC using MPRIS specifications.
> http://specifications.freedesktop.org/mpris-spec/latest/index.html
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/CMakeLists.txt 37769f6 
>   libs/mpris2/mediaplayer2.h PRE-CREATION 
>   libs/mpris2/mediaplayer2.cpp PRE-CREATION 
>   libs/mpris2/mediaplayer2player.h PRE-CREATION 
>   libs/mpris2/mediaplayer2player.cpp PRE-CREATION 
>   libs/mpris2/mpris2.h PRE-CREATION 
>   libs/mpris2/mpris2.cpp PRE-CREATION 
>   mediaelements/mediaplayer/MediaPlayer.qml 39ed617 
>   shells/newshell/mainwindow.cpp c1be61a 
>   shells/newshell/package/contents/ui/mediacenter.qml 50f3576 
> 
> Diff: https://git.reviewboard.kde.org/r/117801/diff/
> 
> 
> Testing
> -------
> 
> Tested with qdbusviewer and mpristester : https://github.com/randomguy3/mpristester
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140427/a4619f0c/attachment-0001.html>