Review Request 117783: Handle QxOrm release and debug mode properly
Bhushan Shah
bhush94 at gmail.com
Sat Apr 26 13:11:43 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117783/
-----------------------------------------------------------
(Updated April 26, 2014, 6:41 p.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
Changes
-------
uploaded wrong patch before
Repository: plasma-mediacenter
Description
-------
Adding -D_QX_RELEASE_MODE when we are linking against QxOrm release mode links fine. As suggested by QxOrm devs
Diffs (updated)
-----
cmake/FindQxOrm.cmake 37c0799
libs/mediacenter/CMakeLists.txt 51f657a
Diff: https://git.reviewboard.kde.org/r/117783/diff/
Testing
-------
1) We are building in Release mode
- QxOrm is in release mode
- QxOrm is in debug mode
- Both release and debug version of QxOrm is available
2) We are building in Debug mode
- QxOrm is in release mode
- QxOrm is in debug mode
- Both release and debug version of QxOrm is available
All pass
Thanks,
Bhushan Shah
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140426/5a9b1b12/attachment.html>
More information about the Plasma-devel
mailing list