Review Request 117784: Remove duplicated ConfigLoader

David Edmundson david at davidedmundson.co.uk
Sat Apr 26 13:00:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117784/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

Remove duplicated ConfigLoaderin Plasma.

This moved to KConfigGui as KConfigLoader.

Use of private KConfig API in Service had to be ported to use only
public method.


Diffs
-----

  autotests/CMakeLists.txt 8501228 
  autotests/configloadertest.h 791b0f6 
  autotests/configloadertest.cpp a89d951 
  autotests/configloadertest.xml 13ccd32 
  src/plasma/CMakeLists.txt a7e9892 
  src/plasma/applet.h 06147fb 
  src/plasma/applet.cpp 88c4973 
  src/plasma/configloader.h 4ef9cb4 
  src/plasma/configloader.cpp 4822548 
  src/plasma/dataengine.cpp 86e33d1 
  src/plasma/private/applet_p.h f31f02e 
  src/plasma/private/configloader_p.h 25bb6b8 
  src/plasma/private/configloaderhandler_p.h df96a33 
  src/plasma/private/service_p.h 3a70392 
  src/plasma/service.cpp 1b3cbaf 

Diff: https://git.reviewboard.kde.org/r/117784/diff/


Testing
-------

Ran plasma shell as before.
plasmaengineexplorer service seems to lists entries correctly.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140426/a551bc4b/attachment-0001.html>


More information about the Plasma-devel mailing list