Review Request 117455: [kglobalaccel] Remove Component::showKCM

Martin Gräßlin mgraesslin at kde.org
Fri Apr 25 17:24:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/
-----------------------------------------------------------

(Updated April 25, 2014, 5:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

[kglobalaccel] Remove Component::showKCM

Component::showKCM was a method exported to DBus to wrap the invocation
of "kcmshell5 keys".

According to lxr there is no application using this DBus method and it's
not much use anyway as it doesn't open the keys KCM for the component.

This removes the KIOWidgets dependency from kglobalaccel.


Diffs
-----

  kglobalaccel/CMakeLists.txt b77f85edab091fd260fb9bddb1ddb43df445c5fe 
  kglobalaccel/component.h 019c315374ecd226cb0820519a76bdbc3ced678c 
  kglobalaccel/component.cpp 72a4980a3c26140bde692d376338da03dc67086e 

Diff: https://git.reviewboard.kde.org/r/117455/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140425/d93f4e9d/attachment.html>


More information about the Plasma-devel mailing list