Review Request 117584: Standardise DBus service CMake code
Commit Hook
null at kde.org
Fri Apr 25 10:06:04 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117584/#review56504
-----------------------------------------------------------
This review has been submitted with commit ad57ea90d1a44b3e9b5feb66f765ff9aad60d750 by Alex Merry to branch master.
- Commit Hook
On April 16, 2014, 10:50 a.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117584/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 10:50 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Standardise DBus service CMake code
>
> Use configure_file() and install() instead of various macros.
>
>
> See https://git.reviewboard.kde.org/r/117581/
>
>
> Diffs
> -----
>
> kuiserver/CMakeLists.txt 5406c2e3663bad98839d9ced3c202969422e64dd
> kglobalaccel/CMakeLists.txt 9606293e1ecbcccefae11bafb4083a181c2a24ba
> krunner/CMakeLists.txt afd5495a39e64bb5ac6f379c6da05d01533df815
> CMakeLists.txt cc591200e719b830cc9b4b6480069851f79743eb
>
> Diff: https://git.reviewboard.kde.org/r/117584/diff/
>
>
> Testing
> -------
>
> Configured, built, installed. Checked (in `make install` output) that files were installed to correct location. Visually inspected installed files.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140425/8d4bfa02/attachment-0001.html>
More information about the Plasma-devel
mailing list