Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock
Thomas Lübking
thomas.luebking at gmail.com
Thu Apr 24 20:01:27 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56415
-----------------------------------------------------------
ksmserver/screenlocker/greeter/main.cpp
<https://git.reviewboard.kde.org/r/117091/#comment39399>
was there a problem with SA_RESTART?
---
KDE Workspaces 4.11.9 tagging:
Fr 25. Apr 01:59:00 CEST 2014
Would you be ok to give Martin until
Fr 25. Apr 00:01:00 CEST 2014
and then push it (on my responsibility)?
- Thomas Lübking
On April 24, 2014, 8:52 a.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117091/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 8:52 a.m.)
>
>
> Review request for kde-workspace, Plasma and Aaron J. Seigo.
>
>
> Bugs: 327947 and 329076
> http://bugs.kde.org/show_bug.cgi?id=327947
> http://bugs.kde.org/show_bug.cgi?id=329076
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> If the screen locker is set to not require a password to unlock, it will not show the password input field even when the powermanagement settings suspend the system and are set to require a password after resume (when it was already running at that point).
> This locks people out of their system.
>
> This patch adds a signal handler for SIGUSR1 that switches the running greeter to immediateLock mode. The locker sends that signal to make sure the greeter shows the password input field when necessary.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/greeterapp.h 8b79188
> ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85
> ksmserver/screenlocker/greeter/main.cpp d898734
> ksmserver/screenlocker/ksldapp.cpp 3dfcc9e
>
> Diff: https://git.reviewboard.kde.org/r/117091/diff/
>
>
> Testing
> -------
>
> Disable "Require password after" in the screen locker settings (the default), set it to start after 1 min. (for easier testing).
> Enable "Suspend session after" and set it to 2 minutes. (set the action to "Suspend", "Hibernate", or "Lock Screen", doesn't matter)
> Make sure "Lock screen on resume" is enabled in the powermanagements "Advanced Options" (it is by default).
>
> After 1 minute the screen locker kicks in, and doesn't require a password.
> After 2 minutes the session gets suspended, hibernated or locked, and requires a password to resume.
>
> Without this patch no password dialog is shown, the user cannot resume the session by entering the password.
>
> With this patch this works: there is a password input field, the session is unlocked when the user enters the password.
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/338cea4d/attachment.html>
More information about the Plasma-devel
mailing list