Review Request 117691: Unload libplasma after using it in Plasma Media Center

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117691/
-----------------------------------------------------------

(Updated April 24, 2014, 5:47 p.m.)


Review request for Plasma and Albert Astals Cid.


Changes
-------

Added CMake option NO_LINK_TO_PLASMA which enables building plasmaadapter and disables linking to plasma.


Repository: plasma-mediacenter


Description
-------

In Kubuntu 14.04 release, we found that Plasma Media Center was unable to play video/audio files. Reason behind it was PMC was linking with libplasma and QtMultimediaKit. libplasma links with libgstreamer1.0 while QtMultimediaKit links with libgstreamer0.10. 

This patch loads libplasma and unloads it after we are done as suggested on http://lists.kde.org/?l=kde-devel&m=139811564632441&w=2 .


Diffs (updated)
-----

  libs/CMakeLists.txt 7e0a9aa 
  libs/plasmaadapter/CMakeLists.txt PRE-CREATION 
  libs/plasmaadapter/plasmaadapter.cpp PRE-CREATION 
  shells/newshell/CMakeLists.txt bc40044 
  shells/newshell/mainwindow.h eb2b276 
  shells/newshell/mainwindow.cpp cfbe097 

Diff: https://git.reviewboard.kde.org/r/117691/diff/


Testing
-------

Able to play audio/video on Kubuntu 14.04 and Fedora 19. 


Thanks,

Sinny Kumari

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/9d1d6bb8/attachment.html>