Review Request 117728: Fix configure when optional packages are missing

Michael Palimaka kensington at gentoo.org
Thu Apr 24 12:35:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117728/
-----------------------------------------------------------

(Updated April 24, 2014, 12:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for kwin and Plasma.


Repository: kwin


Description
-------

Because there is an earlier find_package(KF5 CONFIG REQUIRED), any subsequent find_package(KF5) for optional packages will be treated as required too. Thus configure will fail if optional packages are missing.

Also add some info to the feature summary about what's found or not.


Diffs
-----

  CMakeLists.txt 2334ffc22ed683f528c4ca986a056946143ab41f 

Diff: https://git.reviewboard.kde.org/r/117728/diff/


Testing
-------

Builds with optional packages present and missing.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/8f1197d4/attachment.html>


More information about the Plasma-devel mailing list