Review Request 117632: Plasmoidviewer-Frameworks: Enable the konsole and fix the spacing.

Antonis Tsiapaliokas antonis.tsiapaliokas at kde.org
Thu Apr 24 10:21:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117632/
-----------------------------------------------------------

(Updated April 24, 2014, 10:21 a.m.)


Review request for Plasma.


Repository: plasmate


Description
-------

This patch enables the konsole and it fixes the spacing.
More info on the screenshots.


Diffs (updated)
-----

  plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 

Diff: https://git.reviewboard.kde.org/r/117632/diff/


Testing
-------


File Attachments (updated)
----------------

before
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/8e659a10-f238-440f-b10a-90533880dc99__konsole_spacing-wrong.png
after
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/c9bb85d3-4f8e-4b9c-bbbf-bc80f7ccf71b__konsole_spacing-ok.png
units.largeSpacing/2
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/e019b5ab-ec1b-453d-a730-ac13d60b4c74__konsole_spacing.png
units.largespacing/4
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/0793b296-9490-47a6-8d43-f3c3653201f4__konsole_spacing_units_large.png


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/b4bf93a6/attachment.html>


More information about the Plasma-devel mailing list