Review Request 117494: Proposed Patch for Bug 198661 - Add option to disable scroll on taskbar

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117494/#review56357
-----------------------------------------------------------


We have discussed this before, and the "wheel to enable all kinds of shortcuts" should be a global option, if existing at all. Nobody has bothered to implement this so far, though.

The patch comes late into feature freeze, it adds strings, and is generally undesirable for a feature-frozen codebase. Sorry.

- Sebastian Kügler


On April 11, 2014, 5:38 a.m., Olexa Bilaniuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117494/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 5:38 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 198661
>     https://bugs.kde.org/show_bug.cgi?id=198661
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Patch against plasma-desktop git master rev. ba6f2d7c054e7cdc1013c03a3f0821e8e328329b, fixing Bug 198661 - Add option to disable scroll on taskbar.
> 
> This patch adds a new checkbox under Task Manager Settings > General and a corresponding property called enableMouseScroll, with the default set to True (the current default). This property is checked on every onWheelMoved event, and only if true does it permit scrolling.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/config/main.xml 1a8fe8a 
>   applets/taskmanager/package/contents/ui/ConfigGeneral.qml 114f88a 
>   applets/taskmanager/package/contents/ui/MouseHandler.qml 124e4c9 
>   applets/taskmanager/package/contents/ui/Task.qml b6c3539 
> 
> Diff: https://git.reviewboard.kde.org/r/117494/diff/
> 
> 
> Testing
> -------
> 
> Don't know how to test. However, patch is trivially small; problems should be eyeballable.
> 
> 
> Thanks,
> 
> Olexa Bilaniuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/b57c110f/attachment.html>