Review Request 117540: Improve powermanagement dataengine

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117540/#review56355
-----------------------------------------------------------


We're in feature freeze, and this seems rather non-essential.

I like the idea, though not necessarily exposing this kind of info in the default applet. For that, one could have a separate thing.

- Sebastian Kügler


On April 13, 2014, 1:41 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117540/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 1:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch adds the following functionality provided by Review 117339:
>  - Export temperature
>  - Export voltage
>  - Export energy rate
>  - Export time to full and time to empty for each battery individually
>  - Export serial number
> 
> 
> Diffs
> -----
> 
>   dataengines/powermanagement/powermanagementengine.h 1f1f688 
>   dataengines/powermanagement/powermanagementengine.cpp d0563a7 
> 
> Diff: https://git.reviewboard.kde.org/r/117540/diff/
> 
> 
> Testing
> -------
> 
> Compiles. Data shows up properly in plasmaengineexplorer and is updated when the value changes. 
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140424/178e2c9c/attachment.html>