Review Request 117728: Fix configure when optional packages are missing

Martin Gräßlin mgraesslin at kde.org
Wed Apr 23 19:48:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117728/#review56319
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Gräßlin


On April 23, 2014, 8:33 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117728/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 8:33 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Because there is an earlier find_package(KF5 CONFIG REQUIRED), any subsequent find_package(KF5) for optional packages will be treated as required too. Thus configure will fail if optional packages are missing.
> 
> Also add some info to the feature summary about what's found or not.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2334ffc22ed683f528c4ca986a056946143ab41f 
> 
> Diff: https://git.reviewboard.kde.org/r/117728/diff/
> 
> 
> Testing
> -------
> 
> Builds with optional packages present and missing.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140423/bb08d92b/attachment.html>


More information about the Plasma-devel mailing list