Review Request 117724: Fix plasmoid status when compact plasmoids expand

Marco Martin notmart at gmail.com
Wed Apr 23 16:36:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117724/#review56299
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On April 23, 2014, 4:34 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117724/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 4:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Sets the status to one that actually exists when the dialog is displayed (RequiresAttentionStatus).
> Always set the status back, sometimes it's actually unknown, and it's still a valid status to go back to. Otherwise we keep the plasmoid in RequiresAttentionStatus status and the panel never hides back (if in auto-hide).
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/applet/CompactApplet.qml 8cd8c07 
> 
> Diff: https://git.reviewboard.kde.org/r/117724/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140423/46173c56/attachment.html>


More information about the Plasma-devel mailing list