Review Request 117631: Plasmoidviewer-Frameworks: The konsole button should be visible only if the konsole is enabled.

Commit Hook null at kde.org
Wed Apr 23 15:12:38 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117631/#review56286
-----------------------------------------------------------


This review has been submitted with commit a3bb2315686a65a9c02854d0deeefea6466f4bd7 by Antonis Tsiapaliokas to branch frameworks.

- Commit Hook


On April 23, 2014, 2:38 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117631/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 2:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> The konsole button should be shown only if the konsole is enabled.
> There is no need to show a button which actually does nothing.
> 
> 
> Diffs
> -----
> 
>   plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml afe6c1e 
> 
> Diff: https://git.reviewboard.kde.org/r/117631/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140423/d7b6d685/attachment.html>


More information about the Plasma-devel mailing list