Review Request 117631: Plasmoidviewer-Frameworks: The konsole button should be visible only if the konsole is enabled.

Antonis Tsiapaliokas antonis.tsiapaliokas at kde.org
Wed Apr 23 14:38:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117631/
-----------------------------------------------------------

(Updated April 23, 2014, 2:38 p.m.)


Review request for Plasma.


Changes
-------

Remove the extra property from the SdkButtons.qml.
Also the konsole should be toggled when we press the konsole button.


Repository: plasmate


Description
-------

The konsole button should be shown only if the konsole is enabled.
There is no need to show a button which actually does nothing.


Diffs (updated)
-----

  plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml afe6c1e 

Diff: https://git.reviewboard.kde.org/r/117631/diff/


Testing
-------


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140423/cec2fd21/attachment.html>


More information about the Plasma-devel mailing list