Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

[Christoph Feck]

> On April 20, 2014, 7:18 p.m., Christoph Feck wrote:
> > Can someone more familiar with the screen locker please review this, or suggest someone who could review it?

Felix, could you please add Wolfgang Bauer (wbauer) and maybe Thomas Lübking (luebking) to the reviewers?


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117499/#review56088
-----------------------------------------------------------


On April 11, 2014, 10:23 a.m., Felix Geyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117499/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 10:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 331761
>     http://bugs.kde.org/show_bug.cgi?id=331761
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> The user switichting dialog from the screen locker is destroyed when the cancel button is pressed.
> As a result you can't open it again.
> 
> The screen locker uses a PlasmaComponents.PageStack to show the password input and user switching dialogs.
> When a dialog is popped from the stack it is destroyed by PageStack.
> 
> This change fixes this by creating a new instance of userSessionsUI before it is pushed to the stack.
> Additionally the switchUserEnabled property is set once when the screen locker is created as userSessionsUIInstance
> doesn't always exist. 
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml 0d3c7d5 
> 
> Diff: https://git.reviewboard.kde.org/r/117499/diff/
> 
> 
> Testing
> -------
> 
> - Lock the screen
> - Press "Switch user"
> - Press "Cancel"
> - With this patch the "Switch user" button is visible and functional.
> 
> 
> Thanks,
> 
> Felix Geyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140420/8e4f2863/attachment.html>