Review Request 117533: Fix batterymonitor popup closing when batter full, AC plugged in, and touching brightness slider

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117533/#review56057
-----------------------------------------------------------

Ship it!


I tested for the last couple of days, and found no regressions.

- Christoph Feck


On April 13, 2014, 9:27 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117533/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 9:27 a.m.)
> 
> 
> Review request for Plasma and Christoph Feck.
> 
> 
> Bugs: 321823
>     http://bugs.kde.org/show_bug.cgi?id=321823
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> This fixes the battery monitor popup closing when the AC is plugged in, all batteries are full, and any of the brightness sliders were touched.
> 
> The issue is that changing the plasmoid.status (to Passive?) while the popup is open, causes it to close. Even a check if the current status is the same and not changing it did not help as the plasmoid gets "NeedAttentionStatus" for some reason when it opens. This patch makes it never ever touch the plasmoid.status property while the popup is opened. To ensure the status is still properly set, it will force an update when closing the popup.
> 
> It also changes from legacy string-based enums to real enums.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/contents/code/logic.js def21e5 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml e87cf78 
> 
> Diff: https://git.reviewboard.kde.org/r/117533/diff/
> 
> 
> Testing
> -------
> 
> Changing brightness does not cause the popup to close and status is still properly updated while the popup is not shown.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140419/3727183a/attachment.html>