Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

Martin Klapetek martin.klapetek at gmail.com
Fri Apr 18 10:49:08 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117606/#review56019
-----------------------------------------------------------



src/plasmaquick/appletquickitem.cpp
<https://git.reviewboard.kde.org/r/117606/#comment39038>

    Still misses the {}


- Martin Klapetek


On April 17, 2014, 1:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117606/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 1:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This patch makes sure that the panel containing a plasmoid won't hide when the plasmoid display is open.
> 
> To do so, it sets a AcceptingInputState while caching the last state, to restore it when the plasmoid is contracted back.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/appletquickitem.cpp fbdc88d 
>   src/plasmaquick/private/appletquickitem_p.h 784899a 
> 
> Diff: https://git.reviewboard.kde.org/r/117606/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140418/19c80bb7/attachment.html>


More information about the Plasma-devel mailing list