Review Request 117404: Don't build tests if QtTest is not found

Martin Gräßlin mgraesslin at kde.org
Fri Apr 18 08:15:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117404/#review56010
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Gräßlin


On April 18, 2014, 10:04 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117404/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 10:04 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> If QtTest is not found, don't try to build tests. Also add a feature_summary so we can see what's happening.
> Not really sure where to send the review, so leaving it as plasma since it was split from kde-workspace.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt acdfb319d76a9aaf6b5d74b70b138d302e3d6b0b 
> 
> Diff: https://git.reviewboard.kde.org/r/117404/diff/
> 
> 
> Testing
> -------
> 
> Builds with/without tests as expected.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140418/19311be3/attachment-0001.html>


More information about the Plasma-devel mailing list