Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center

Harshit Agarwal see.harshit at gmail.com
Thu Apr 17 17:52:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117615/
-----------------------------------------------------------

Review request for Plasma, Akshay Ratan, Shantanu Tushar, and Sinny Kumari.


Repository: plasma-mediacenter


Description
-------

I have implemented the local browsing search only to the Videos section as of now, but the application crashes, and it searches on the drive selection window, but doesn't search on the folder and file selection window after that. Please look into it and suggest where I am going wrong.

Once this is done, it's the same implementation for images and songs. I would do that similarly.


Diffs
-----

  browsingbackends/localfiles/localfilesabstractbackend.h 2d47eba 
  browsingbackends/localfiles/localfilesabstractbackend.cpp b86a28a 
  browsingbackends/localfiles/localvideos/localvideosbackend.h ce92a9e 
  browsingbackends/localfiles/localvideos/localvideosbackend.cpp 8c20f27 

Diff: https://git.reviewboard.kde.org/r/117615/diff/


Testing
-------

Errors yet there so testing on hold.


Thanks,

Harshit Agarwal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140417/c1536325/attachment-0001.html>


More information about the Plasma-devel mailing list