Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117606/#review55951
-----------------------------------------------------------


If it's for the panel, it shouldn't be done in AppletQuickItem.
also using AcceptingInputStatus seems a tad arbitrary?


src/plasmaquick/appletquickitem.cpp
<https://git.reviewboard.kde.org/r/117606/#comment38994>

    compactStatus doesn't seem to be ever initialized.
    so seems to depend on the assumption this branch of the if will always execute at least once before the other one



src/plasmaquick/appletquickitem.cpp
<https://git.reviewboard.kde.org/r/117606/#comment38993>

    coding styles:
    always
    if () {
    
    }


- Marco Martin


On April 16, 2014, 11:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117606/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 11:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This patch makes sure that the panel containing a plasmoid won't hide when the plasmoid display is open.
> 
> To do so, it sets a AcceptingInputState while caching the last state, to restore it when the plasmoid is contracted back.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/appletquickitem.cpp fbdc88d 
>   src/plasmaquick/private/appletquickitem_p.h 784899a 
> 
> Diff: https://git.reviewboard.kde.org/r/117606/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140417/3286937c/attachment.html>