Review Request 117414: [ksmserver/screenlocker] Port greeter away from kde4support
Martin Gräßlin
mgraesslin at kde.org
Wed Apr 16 11:41:49 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117414/
-----------------------------------------------------------
(Updated April 16, 2014, 11:41 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and David Edmundson.
Repository: plasma-workspace
Description
-------
[ksmserver/screenlocker] Port greeter away from kde4support
* Drop unused KDebug include
* Port from KStandarDirs to QStandardPaths
* Drop unused kglobalsettings include
[ksmserver/screenlocker] Port Greeter from KApplication to QApplication
* Use QCommandLineParser instead of KCmdLineArgs
* Inherit QApplication instead of KApplication
* Use QCoreApplication::setApplicationName and friends
* Drop k4aboutdata
Diffs
-----
ksmserver/screenlocker/greeter/CMakeLists.txt 5792ce7e9b6cf3b5924ce56ea294605dff3a2de6
ksmserver/screenlocker/greeter/greeterapp.h 7b78257211a1dde34a43b96493d40796e44343a5
ksmserver/screenlocker/greeter/greeterapp.cpp 1af4d2f2879d2c1165fa63976fa1d41eef217ff0
ksmserver/screenlocker/greeter/main.cpp 4d2203995775e9e1df1fac41244c2d6270401b9f
ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg 5aa9d32adeca1cdc549e39893d8af7c05163a660
Diff: https://git.reviewboard.kde.org/r/117414/diff/
Testing
-------
Thanks,
Martin Gräßlin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140416/ce188f80/attachment.html>
More information about the Plasma-devel
mailing list