Review Request 117417: [ksmserver/screenlocker] Port the locker library away from kde4support

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117417/#review55692
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On April 7, 2014, 9:09 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117417/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 9:09 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [ksmserver/screenlocker] Port the locker library away from kde4support
> 
> 
> [ksmserver/screenlocker] KApplication -> QApplication
> 
> 
> [ksmserver/screenlocker] kDebug -> qDebug
> 
> 
> [ksmserver/screenlocker] Drop usage of KDialog
> 
> Not really needed.
> 
> [ksmserver/screenlocker] Hard-code path to screenlocker_greet
> 
> Porting away from KStandardDirs. As it used to be libexec it's now hard
> coded through the config-ksmserver.h.cmake.
> 
> 
> Diffs
> -----
> 
>   ksmserver/config-ksmserver.h.cmake 2ad0394a10c0720b02c87a7399641619e819d907 
>   ksmserver/screenlocker/CMakeLists.txt 9aeec778c58686b4cac8c139dade00a57f69e999 
>   ksmserver/screenlocker/autologout.cpp 2a5eaf266eaf65a93b8cbf59eec45f9d2d536f82 
>   ksmserver/screenlocker/ksldapp.cpp c2db0425d87737a0052792f763737a2a2ec96f18 
>   ksmserver/screenlocker/lockwindow.cpp 5ca93a6075c5fa4b34ac84cd293e99044cc18df0 
> 
> Diff: https://git.reviewboard.kde.org/r/117417/diff/
> 
> 
> Testing
> -------
> 
> Only compile tested so far as it needs restarting ksmserver.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140414/7710c928/attachment-0001.html>