Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForRole()

Sinny Kumari ksinny at gmail.com
Sun Apr 13 15:17:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117510/#review55607
-----------------------------------------------------------

Ship it!


Ship It!


libs/mediacenter/media.cpp
<https://git.reviewboard.kde.org/r/117510/#comment38688>

    Please remove whitespace before colon


- Sinny Kumari


On April 12, 2014, 10:55 a.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117510/
> -----------------------------------------------------------
> 
> (Updated April 12, 2014, 10:55 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Remove the function extractAndSaveDurationInfo() and add a case for MediaCenter::DurationRole in setValueForRole().
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/media.cpp 3ba5d9e 
>   libs/mediacenter/medialibrary.h 3ac18a6 
>   libs/mediacenter/medialibrary.cpp 713827a 
> 
> Diff: https://git.reviewboard.kde.org/r/117510/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140413/2cafe972/attachment-0001.html>


More information about the Plasma-devel mailing list