Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

R.Harish Navnit harishnavnit at gmail.com
Sat Apr 12 15:23:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
-----------------------------------------------------------

(Updated April 12, 2014, 3:23 p.m.)


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Changes
-------

Added enabled property to the mediaplayer buttons, and changes to the playNext function. 


Bugs: 330990 and Bug
    http://bugs.kde.org/show_bug.cgi?id=330990
    http://bugs.kde.org/show_bug.cgi?id=Bug


Repository: plasma-mediacenter


Description
-------

Now the next and previous buttons do not work unless a media is playing. 


Diffs (updated)
-----

  mediaelements/mediacontroller/MediaController.qml 2fce0a0 
  mediaelements/playlist/Playlist.qml 5dde297 

Diff: https://git.reviewboard.kde.org/r/116874/diff/


Testing
-------

I've done the testing for this patch.

These are the steps that I followed. 
1. Added a new playlist and added a few songs to the playlist.
2. Re-opened Plasma Media Center 
3. Clicked the Next and Previous buttons.
4. Nothing was played.
5. Selected a song from the list and then tested the next and previous buttons.
6. The buttons worked seamlessly.  


Thanks,

R.Harish  Navnit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140412/e4c686e3/attachment.html>


More information about the Plasma-devel mailing list