Review Request 117452: [kglobalaccel] Port away from dead #ifdef Q_WS_X11

Martin Gräßlin mgraesslin at kde.org
Thu Apr 10 05:58:00 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117452/
-----------------------------------------------------------

(Updated April 10, 2014, 7:58 a.m.)


Review request for Plasma.


Changes
-------

simplified the sync method


Repository: plasma-workspace


Description
-------

[kglobalaccel] Port away from dead #ifdef Q_WS_X11

* Add a configure-kglobalaccel.h which defines HAVE_X11
* Port all Q_WS_X11 to HAVE_X11
* Implement a replacement for qApp->syncX()


Diffs (updated)
-----

  kglobalaccel/CMakeLists.txt b77f85edab091fd260fb9bddb1ddb43df445c5fe 
  kglobalaccel/component.cpp 72a4980a3c26140bde692d376338da03dc67086e 
  kglobalaccel/config-kglobalaccel.h.cmake PRE-CREATION 
  kglobalaccel/globalshortcutsregistry.cpp 41a351b47a66c24f2e25d0d0d1df9c8a9b6616ef 
  kglobalaccel/kglobalaccel_x11.h c0e9334517e3954dde211fd5d79e59f4bb56e2bd 
  kglobalaccel/kglobalaccel_x11.cpp 9da8907485b55d522299200b4e5db307a73ae4e4 

Diff: https://git.reviewboard.kde.org/r/117452/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140410/63f1e6e2/attachment.html>


More information about the Plasma-devel mailing list