Review Request 117463: kinfocenter: minor dependencies cleanup

David Stephen Hubner hubnerd at ntlworld.com
Thu Apr 10 00:32:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117463/#review55320
-----------------------------------------------------------

Ship it!


Looks good to me. Ship It :)

- David Stephen Hubner


On April 10, 2014, 12:29 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117463/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 12:29 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, Martin Gräßlin, and David Stephen Hubner.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> 1) QtGui is needed to determine openGL implementation (GL vs GL ES)
> 2) Completion, Config and KIO are explicit link targets so search for them
> 3) DocTools are needed for doc dir
> 4) Zlib and XCB:: are not needed
> 5) Minor description improvements
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 869e65a 
> 
> Diff: https://git.reviewboard.kde.org/r/117463/diff/
> 
> 
> Testing
> -------
> 
> Built successfully with CMake 3.0.0-rc3 & Frameworks HEAD.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140410/f573b420/attachment-0001.html>


More information about the Plasma-devel mailing list