Review Request 117448: Port startkde script to KF5

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117448/#review55286
-----------------------------------------------------------



startkde/startkde.cmake
<https://git.reviewboard.kde.org/r/117448/#comment38496>

    just a question, why this change? qtpaths comes from qttools (same as qdbus), and kf5-config from kdelibs4support, so this looks like a step backwards, and makes it harder later to move on from using kde4support...
    (same for qt_plugin_path change)


- Hrvoje Senjan


On April 9, 2014, 12:18 p.m., Johannes Huber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117448/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 12:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> - Use correct version variable
> - Uses the provided binaries from KF5
> - Fix comments
> 
> 
> Diffs
> -----
> 
>   startkde/startkde.cmake e845603 
> 
> Diff: https://git.reviewboard.kde.org/r/117448/diff/
> 
> 
> Testing
> -------
> 
> It builds. Further runtime tests needed later when Plasma2 is completly packaged downstream.
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140409/fe3c2e96/attachment.html>