Review Request 117447: Runner - QueryMatch: Allow each match to give a category

[Marco Martin]

> On April 9, 2014, 11:27 a.m., Marco Martin wrote:
> > I like the idea, only two things:
> > * I am not sure about the default, would rather have it empty so everybody that doesn't set it goes in a "misc" section
> > * if this goes in, i would like to see sprinter's querymatch have the same, to avoid "oh crap" moments when porting
> 
> Marco Martin wrote:
>     (is pretty much corresponding to matchtype in sprinter if i understood correctly?)
> 
> Aleix Pol Gonzalez wrote:
>     About the default, we discussed it a bit shortly and it seems like runners are _never_ sharing categories. If we haven't found a use-case yet, I wouldn't expect it to happen now.
>     
>     Creating a shared misc category sounds artificial to me.
>

uhm, i can easily think about different runners returning website urls, or resutls of type "video" regardless if is a search on the filesystem or from a youtube runner..


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117447/#review55272
-----------------------------------------------------------


On April 9, 2014, 11:18 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117447/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 11:18 a.m.)
> 
> 
> Review request for Plasma and Aleix Pol Gonzalez.
> 
> 
> Repository: krunner
> 
> 
> Description
> -------
> 
> 
>     This string based category is useful in categorizing the results. By
>     default the category defaults to the name of the runner.
> 
> 
> Diffs
> -----
> 
>   src/querymatch.h afec76e 
>   src/querymatch.cpp 83888f7 
> 
> Diff: https://git.reviewboard.kde.org/r/117447/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140409/07dafdb5/attachment.html>