Review Request 117393: Make building tests optional

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117393/#review55226
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/117393/#comment38469>

    not sure whether this or "KDE4_BUILD_TESTS" is the "right" one, but this should be sorted out



autotests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117393/#comment38470>

    why not find this in the
    if (CORRECT_TEST_BUILD_FLAG)
    branch instead of finding the lib in every subdir?



kcmkwin/kwincompositing/test/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117393/#comment38471>

    i would object this backreferencing (building tests w/o building source should be prohibited) but it's apparently done in autotests/CMakeLists.txt as well, so not an issue with this patch, just for general consideration.



libkwineffects/CMakeLists.txt
<https://git.reviewboard.kde.org/r/117393/#comment38472>

    it *might* be reasonable to add all testing dirs conditionally from the toplevel CMakeLists.txt - esp. if the lib requirements are checked there as well


- Thomas Lübking


On April 7, 2014, 2:50 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117393/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 2:50 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Add option to disable building tests, and move the QtTest dependency to be required only for tests.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 35fb9ac3b0f8506e6f0fd92b48ba60e83524f212 
>   autotests/CMakeLists.txt 475a7a5f9013ed16d37777bc05e9cba2ad033338 
>   kcmkwin/kwincompositing/CMakeLists.txt 8eb170bedd32f04f5d2cc0fbd3079758e6138cc6 
>   kcmkwin/kwincompositing/test/CMakeLists.txt PRE-CREATION 
>   libkwineffects/CMakeLists.txt 0544b0d441f3685240160f15e6c9890c8a92fec1 
>   libkwineffects/autotests/CMakeLists.txt 8973545cc21b010f1430cf7df20a29da5b14ab43 
>   tabbox/CMakeLists.txt 76ba3a2499ca142bb82109db9d7239001ed7157e 
>   tabbox/autotests/CMakeLists.txt 4e83fa7524483d64ea149f0eb1818ea9f61cffe0 
> 
> Diff: https://git.reviewboard.kde.org/r/117393/diff/
> 
> 
> Testing
> -------
> 
> Builds. Tests pass (when enabled).
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140408/d14e2688/attachment.html>