Review Request 117433: [applets/notifications] Use ::hide() instead of ::close()

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117433/#review55217
-----------------------------------------------------------


> @MartinK: was there a specific reason to use QWindow::close()? Will using hide() cause problems?

Yes the reason was that the Dialogs would just pile up in memory after time if they were just hidden, so I went for closing them (which also deleteLaters them) to save memory.

However I'm rewriting this part to recycle only couple Dialogs, this will also just hide them instead of close.

- Martin Klapetek


On April 8, 2014, 11:49 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117433/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 11:49 a.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [applets/notifications] Use ::hide() instead of ::close()
> 
> QWindow::close() is destroying the window directly, while ::hide() just
> unmaps the window. The main difference is that with hide() the window
> manager can still access the x window in the close handling and with
> close that's not possible and KWin generates runtime errors.
> 
> @MartinK: was there a specific reason to use QWindow::close()? Will using hide() cause problems?
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml f738e000b4a28c8c43cbbb9410a53f8b34e4fc56 
>   applets/notifications/plugin/notificationshelper.cpp 9cc119151232d244b4a05d89f07069a80b1da96c 
> 
> Diff: https://git.reviewboard.kde.org/r/117433/diff/
> 
> 
> Testing
> -------
> 
> KWin doesn't print warnings when a notification closes.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140408/5e1f46ec/attachment.html>