Review Request 117411: [ksmserver/screenlocker] Remove support for legacy screen saver

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117411/#review55114
-----------------------------------------------------------



ksmserver/screenlocker/greeter/greeterapp.cpp
<https://git.reviewboard.kde.org/r/117411/#comment38423>

    This assert looks wrong; we've removed the code to update m_screensaverWindows. (formerly line 151 and 231) so this assert is going to fail.
    
    In fact why does m_screensaverWindows to exist?



ksmserver/screenlocker/greeter/greeterapp.cpp
<https://git.reviewboard.kde.org/r/117411/#comment38422>

    This line seems important. 
    
    Can you check the caps key warning is still working before pushing.
    
    


- David Edmundson


On April 7, 2014, 6:43 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117411/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 6:43 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [ksmserver/screenlocker] Remove support for legacy screen saver
> 
> The remaining support for the legacy X screen savers is removed from
> the greeter application.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 5792ce7e9b6cf3b5924ce56ea294605dff3a2de6 
>   ksmserver/screenlocker/greeter/greeterapp.h 7b78257211a1dde34a43b96493d40796e44343a5 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 1af4d2f2879d2c1165fa63976fa1d41eef217ff0 
>   ksmserver/screenlocker/greeter/screensaverwindow.h 90214d81572fd87d5a9832df74c8d1e60097e210 
>   ksmserver/screenlocker/greeter/screensaverwindow.cpp b216f692dceaca6330430c0f008db510a51e63a3 
>   ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg cf77e7aa6c684d67587b66d45abd27de74743379 
> 
> Diff: https://git.reviewboard.kde.org/r/117411/diff/
> 
> 
> Testing
> -------
> 
> screenlocker still works
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140407/f4b61d8c/attachment.html>