Review Request 117324: Add logind integration to screenlocker

Martin Gräßlin mgraesslin at kde.org
Fri Apr 4 07:34:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117324/
-----------------------------------------------------------

(Updated April 4, 2014, 9:34 a.m.)


Review request for Plasma, Àlex Fiestas, David Edmundson, and Kirill Elagin.


Changes
-------

Made the blocking calls async


Bugs: 314989
    https://bugs.kde.org/show_bug.cgi?id=314989


Repository: plasma-workspace


Description
-------

Add logind integration to screenlocker

A new class LogindIntegration is added to the screenlocker. This class
listens to the Lock and Unlock signals emitted by the session object on
the logind service.

This is integrated with the screenlocker application to start or quit the
lock when the signals are emitted. This means a locked screen is unlocked
when the Unlock signal is received from logind. Logind is a higher
authority for the screenlocker and thus follows the requests from logind.


Diffs (updated)
-----

  ksmserver/screenlocker/logind.cpp PRE-CREATION 
  ksmserver/screenlocker/logind.h PRE-CREATION 
  ksmserver/screenlocker/ksldapp.cpp f2e5262 
  ksmserver/screenlocker/autotests/logindtest.cpp PRE-CREATION 
  ksmserver/screenlocker/autotests/fakelogind.cpp PRE-CREATION 
  ksmserver/screenlocker/autotests/fakelogind.h PRE-CREATION 
  ksmserver/screenlocker/autotests/CMakeLists.txt PRE-CREATION 
  ksmserver/screenlocker/CMakeLists.txt 55ebc6f 

Diff: https://git.reviewboard.kde.org/r/117324/diff/


Testing
-------

so far only tested with the unit test. Still need to restart the session.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140404/98a9ed37/attachment-0001.html>


More information about the Plasma-devel mailing list