Review Request 117121: Add property to determine if popups should be inside or outside the parentItem

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117121/
-----------------------------------------------------------

(Updated April 3, 2014, 1:24 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasma-framework


Description
-------

Add property to determine if popups should be inside or outside the parentItem

For some cases of dialog we want to position within the parent item for
example widget explorer. For popup applets on the desktop the dialog
should appear outside of the parentItem.

Currently we try to determine it automatically from the window type of
the parentItem. This worked fine for widget explorer and panels, but
breaks for popup applets on the desktop.


Diffs
-----

  src/plasmaquick/dialog.h 3804d18 
  src/plasmaquick/dialog.cpp 77c0c8c 

Diff: https://git.reviewboard.kde.org/r/117121/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140403/c9b8c50d/attachment.html>