Review Request 117336: Find Qt5WebKitWidgets directly

David Edmundson david at davidedmundson.co.uk
Wed Apr 2 16:07:57 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117336/#review54888
-----------------------------------------------------------


You can just merge it into the line above now.
There's no point keeping it optional, one can just not build the ksysguard repo now if they don't have it.

- David Edmundson


On April 2, 2014, 3:49 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117336/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 3:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> If Qt5WebKitWidgets is not found or disabled, it can cause Qt5 to be considered not found. Moving from find_package(Qt5) to finding the package directly solves this problem.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 35acb2573b739aded6ce7a9411c2be9fe432af64 
> 
> Diff: https://git.reviewboard.kde.org/r/117336/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests OK.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140402/07660a1d/attachment.html>


More information about the Plasma-devel mailing list