Review Request 117321: Add password checking to screenlocker

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117321/#review54859
-----------------------------------------------------------

Ship it!


- David Edmundson


On April 2, 2014, 6:29 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117321/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 6:29 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Add password checking to screenlocker
>     
> A new Authenticator item is introduced and exported to QML. It provides
> a slot tryAuthenticate taking the password as a string. If invoked it
> creates a KCheckPass object which handles the communication with the
> kcheckpass binary to verify the password. If the authentication succeeded
> the Authenticator emits a succeeded() signal, on failure a failed()
> signal.
> 
> The authentication process is bound to a grace timer. While this timer is
> active it's not possible to authenticate again. This state is exposed
> with a Q_PROPERTY and used by the UI to disable the password field and
> unlock button.
> 
> 
> Diffs
> -----
> 
>   ksmserver/config-ksmserver.h.cmake 4b60c8c 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 53fe38b 
>   ksmserver/screenlocker/greeter/authenticator.h PRE-CREATION 
>   ksmserver/screenlocker/greeter/authenticator.cpp PRE-CREATION 
>   ksmserver/screenlocker/greeter/autotests/CMakeLists.txt PRE-CREATION 
>   ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp PRE-CREATION 
>   ksmserver/screenlocker/greeter/autotests/fakekcheckpass.c PRE-CREATION 
>   ksmserver/screenlocker/greeter/greeterapp.h 7a84bb4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 496c012 
>   ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml 7aa59f8 
> 
> Diff: https://git.reviewboard.kde.org/r/117321/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140402/8c3ebb76/attachment.html>