Review Request 117312: Disable PackageKit integration

Marco Martin notmart at gmail.com
Wed Apr 2 08:39:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117312/#review54846
-----------------------------------------------------------


it's probably good having it build optionally...
but disabling it konvby default looks a bit too much swiping under the carpet to me.
I do have some packagekit messages, but thinks like "unable to fina a package called "data engine".
This looks incorrect no matter what, i suspect there is some problem regardless of it being useful or not right now, because those messages in particular should just not be there

- Marco Martin


On April 1, 2014, 9:48 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117312/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 9:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> imho, it doesn't make sense at this stage, and just spams people that have PK installed...
> 
> 
> Diffs
> -----
> 
>   src/plasma/CMakeLists.txt 90c020e 
> 
> Diff: https://git.reviewboard.kde.org/r/117312/diff/
> 
> 
> Testing
> -------
> 
> builds. before the patch -DPLASMA_ENABLE_PACKAGEKIT_SUPPORT=1 definition was added, no definition w/ patch
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140402/61022723/attachment.html>


More information about the Plasma-devel mailing list