Review Request 117276: Add password checking to screenlocker

Martin Gräßlin mgraesslin at kde.org
Wed Apr 2 06:29:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117276/
-----------------------------------------------------------

(Updated April 2, 2014, 8:29 a.m.)


Status
------

This change has been discarded.


Review request for Plasma and David Edmundson.


Repository: kde-workspace


Description
-------

Add password checking to screenlocker

A new Authenticator item is introduced and exported to QML. It provides
a slot tryAuthenticate taking the password as a string. If invoked it
creates a KCheckPass object which handles the communication with the
kcheckpass binary to verify the password. If the authentication succeeded
the Authenticator emits a succeeded() signal, on failure a failed()
signal.

The authentication process is bound to a grace timer. While this timer is
active it's not possible to authenticate again. This state is exposed
with a Q_PROPERTY and used by the UI to disable the password field and
unlock button.


Diffs
-----

  plasma-workspace/ksmserver/config-ksmserver.h.cmake 4b60c8c6713089db8c637827c44bb04c37a87abe 
  plasma-workspace/ksmserver/screenlocker/greeter/CMakeLists.txt 53fe38b7452a179f5919e93585573038ea926d00 
  plasma-workspace/ksmserver/screenlocker/greeter/authenticator.h PRE-CREATION 
  plasma-workspace/ksmserver/screenlocker/greeter/authenticator.cpp PRE-CREATION 
  plasma-workspace/ksmserver/screenlocker/greeter/autotests/CMakeLists.txt PRE-CREATION 
  plasma-workspace/ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp PRE-CREATION 
  plasma-workspace/ksmserver/screenlocker/greeter/autotests/fakekcheckpass.c PRE-CREATION 
  plasma-workspace/ksmserver/screenlocker/greeter/greeterapp.h 7a84bb44bed1afd879b6a02bed1a6265f62cb508 
  plasma-workspace/ksmserver/screenlocker/greeter/greeterapp.cpp 496c0128e6a240a0821848c054ed60e2c2730f04 
  plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml 7aa59f81f7257db9ed8306bf732b008036c64d95 

Diff: https://git.reviewboard.kde.org/r/117276/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140402/7dc5f548/attachment.html>


More information about the Plasma-devel mailing list