Review Request 117310: Improve tests

Aleix Pol Gonzalez aleixpol at kde.org
Wed Apr 2 00:56:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117310/#review54832
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On April 1, 2014, 6:01 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117310/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 6:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> QtTest is only required for tests, so move it there and add the option to avoid building them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4d3a76eb7f041d45ef545f817a39db8e8080ce9e 
>   tests/CMakeLists.txt 1826b216b4993145723818551c1dd52872b0a9bb 
> 
> Diff: https://git.reviewboard.kde.org/r/117310/diff/
> 
> 
> Testing
> -------
> 
> Builds as expected both with and without tests enabled.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140402/37f357bb/attachment.html>


More information about the Plasma-devel mailing list