Review Request 117309: Fix build without X11

Aleix Pol Gonzalez aleixpol at kde.org
Wed Apr 2 00:47:02 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117309/#review54831
-----------------------------------------------------------


If it wasn't found, it should be false. Why's that wrong?

- Aleix Pol Gonzalez


On April 1, 2014, 5:54 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117309/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 5:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: libksysguard
> 
> 
> Description
> -------
> 
> If X11 was not found, HAVE_X11 would be unset resulting in literal "#if ".
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4d3a76eb7f041d45ef545f817a39db8e8080ce9e 
>   config-ksysguard.h.cmake 9928bc16cf0de32f6b051e7746ae77cbb2d35991 
> 
> Diff: https://git.reviewboard.kde.org/r/117309/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests pass both with and without X11.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140402/a4e05960/attachment.html>


More information about the Plasma-devel mailing list