Review Request 117276: Add password checking to screenlocker

[Kai Uwe Broulik]

> On April 1, 2014, 8:31 a.m., Kai Uwe Broulik wrote:
> > plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml, line 47
> > <https://git.reviewboard.kde.org/r/117276/diff/1/?file=262163#file262163line47>
> >
> >     Imho it should be possible to tell whether it failed due to credentials (wrong password) or the service is unavailable (eg. ldap/network error)
> 
> Martin Gräßlin wrote:
>     need to connect the messages which would hopefully tell it. I don't know whether kcheckpass provides this information.

You might want to look at [kde-workspace KDE/4.11] ksmserver/screenlocker/greeter/greeter.cpp which triggers said message in gplugStart() and/or reapVerify()


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117276/#review54742
-----------------------------------------------------------


On April 1, 2014, 10:10 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117276/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 10:10 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Add password checking to screenlocker
> 
> A new Authenticator item is introduced and exported to QML. It provides
> a slot tryAuthenticate taking the password as a string. If invoked it
> creates a KCheckPass object which handles the communication with the
> kcheckpass binary to verify the password. If the authentication succeeded
> the Authenticator emits a succeeded() signal, on failure a failed()
> signal.
> 
> The authentication process is bound to a grace timer. While this timer is
> active it's not possible to authenticate again. This state is exposed
> with a Q_PROPERTY and used by the UI to disable the password field and
> unlock button.
> 
> 
> Diffs
> -----
> 
>   plasma-workspace/ksmserver/config-ksmserver.h.cmake 4b60c8c6713089db8c637827c44bb04c37a87abe 
>   plasma-workspace/ksmserver/screenlocker/greeter/CMakeLists.txt 53fe38b7452a179f5919e93585573038ea926d00 
>   plasma-workspace/ksmserver/screenlocker/greeter/authenticator.h PRE-CREATION 
>   plasma-workspace/ksmserver/screenlocker/greeter/authenticator.cpp PRE-CREATION 
>   plasma-workspace/ksmserver/screenlocker/greeter/autotests/CMakeLists.txt PRE-CREATION 
>   plasma-workspace/ksmserver/screenlocker/greeter/autotests/authenticatortest.cpp PRE-CREATION 
>   plasma-workspace/ksmserver/screenlocker/greeter/autotests/fakekcheckpass.c PRE-CREATION 
>   plasma-workspace/ksmserver/screenlocker/greeter/greeterapp.h 7a84bb44bed1afd879b6a02bed1a6265f62cb508 
>   plasma-workspace/ksmserver/screenlocker/greeter/greeterapp.cpp 496c0128e6a240a0821848c054ed60e2c2730f04 
>   plasma-workspace/ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml 7aa59f81f7257db9ed8306bf732b008036c64d95 
> 
> Diff: https://git.reviewboard.kde.org/r/117276/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140401/5b1095c0/attachment.html>