Review Request 112959: Add color picker in plasmaextracomponents

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112959/#review40860
-----------------------------------------------------------



src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml
<http://git.reviewboard.kde.org/r/112959/#comment30029>

    Class needs a global documentation



src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml
<http://git.reviewboard.kde.org/r/112959/#comment30028>

    properties need documentation



src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml
<http://git.reviewboard.kde.org/r/112959/#comment30030>

    to be correct, assigning an hue (or saturation, or lightness) should update the color as well
    
    tough payiung attention it doesn't cause a binding loop



src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml
<http://git.reviewboard.kde.org/r/112959/#comment30027>

    every hardcoded size must disappear before having it on public api


- Marco Martin


On Sept. 26, 2013, 12:49 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112959/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 12:49 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> Add color picker in PlasmaExtras
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml PRE-CREATION 
>   src/declarativeimports/plasmaextracomponents/qml/qmldir c59e62f 
> 
> Diff: http://git.reviewboard.kde.org/r/112959/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130926/c3a58e86/attachment.html>