Review Request 112888: Roughly port icon applet to plasma2

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40557
-----------------------------------------------------------



plasma/generic/applets/icon/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/112888/#comment29879>

    spaces around == and || make it more readable


- Sebastian Kügler


On Sept. 23, 2013, 12:37 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 12:37 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> -------
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> ----------------
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130923/12b0b9dc/attachment.html>