Review Request 112723: add a visible property in the toolBox

Sebastian Kügler sebas at kde.org
Sat Sep 14 18:22:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112723/#review40026
-----------------------------------------------------------


Why should the (abstract) toolbox care? What do you want to achieve?

- Sebastian Kügler


On Sept. 14, 2013, 11:38 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112723/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2013, 11:38 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> The toolBox should have a visible property in order to be
> possible to do
> 
> property Item toolBox
> onToolBoxChanged: {
>     visible: false
> }
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 4e100d9 
> 
> Diff: http://git.reviewboard.kde.org/r/112723/diff/
> 
> 
> Testing
> -------
> 
> the default value of the visible property is true,
> so the existing behavior doesn't change.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130914/399b7e9c/attachment-0001.html>


More information about the Plasma-devel mailing list