Review Request 112208: KMix qml applet

[Sebastian Kügler]

> On Aug. 22, 2013, 2:34 p.m., Sebastian Kügler wrote:
> > File Attachment: Vertical Control
> > <http://git.reviewboard.kde.org/r/112208/#fcomment92>
> >
> >     Clipping
> 
> Diego Casella wrote:
>     This falls in the "known issues -> resizing" stuff: it is kinda hard to get the sizes right but the applet itself is resizeable so, until we get this right, the user can expand it as much as needed to fix it. That operation needs to be done only once because then plasma keeps track of it, so it would be a single-time hassle.. what do you think?

It should look neat by default. First impression is everything, and the user doesn't want to resize all kinds of dialogs, so they fit nicely. This leads to a jarring user experience. 
A good way to get to a somewhat adaptable UI is basing the sizing, or the margins on font sizes, i.e. theme.defaultFont.mSize, or theme.defaultFont.pixelSize, so dpi is taken into account as well. Or just add a few pixels of margin.

There's another issue with this, the dialog contents isn't anchored properly to the dialog, so resizing doesn't resize the content. This will need to be fixed independently, and should hopefully fix the clipping of the last rows, being overlaid by the button row.


> On Aug. 22, 2013, 2:34 p.m., Sebastian Kügler wrote:
> > plasma/CMakeLists.txt, line 2
> > <http://git.reviewboard.kde.org/r/112208/diff/1/?file=183950#file183950line2>
> >
> >     use the installPackage macro for this and the following line
> 
> Diego Casella wrote:
>     First it needs to be exported, since it lives inside kde-workspace/plasma/CMakeLists.txt ;)

Ah, ok. In Plasma2, it's indeed in PlasmaMacros, you can keep it that way, and we'll change it post-port-to-plasma2. 


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112208/#review38344
-----------------------------------------------------------


On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and Igor Poboiko.
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you can display all the controls available, change its orientation, and decide to whether show all of them or just the Master Control, and refresh its status when new controls are added/removed/updated (such as Amarok current playing track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but honestly opening the audio applet to change/skip/pause audio track makes little sense to me ... if anyone wants this feature back, don't be shy and step in);
> * the button used to select which Mixers are visible has been changed to open Phonon kcm page: since visible mixers are already configurable from KMix app, having a button to show KMix *and* a button to modify Mixers visibilty made little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the popupIcon, so it is not possible to scroll over to increase/decrease the master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon but, if you do so, KMix will show its GUI at every login and you have to close it manually. This requires KMix to be patched. Furthermore, if you click "KMix Setup" button, KMix window will not restored anymore: this needs to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> Control Icon and Label left aligned
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130902/11cdf03a/attachment-0001.html>