Review Request 112447: implement the PlasmaView library

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112447/#review39151
-----------------------------------------------------------



src/plasmaview/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112447/#comment28880>

    ${KI18n_LIBARIES}



src/plasmaview/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112447/#comment28881>

    ${KService_LIBRARIES}



src/plasmaview/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112447/#comment28882>

    ${KCoreAddons_LIBRARIES}



src/plasmaview/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112447/#comment28883>

    $KXmlGui_LIBRARIES}
    
    ... I guess, look it up in plasma-framework/CMakeLists.txt if it doesn't work.



src/plasmaview/PlasmaViewConfig.cmake.in
<http://git.reviewboard.kde.org/r/112447/#comment28886>

    This should probably be KF5::PlasmaView, to make camelcasing more consistent


Some minor issues in the cmake var referencing, otherwise, looks good from my side.

- Sebastian Kügler


On Sept. 2, 2013, 12:53 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112447/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 12:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch creates a new library out of the shell dir.
> We need this library in order to implement plasmoidviewer 2.0
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 281d146 
>   src/plasmaview/CMakeLists.txt PRE-CREATION 
>   src/plasmaview/PlasmaViewConfig.cmake.in PRE-CREATION 
>   src/plasmaview/configview.h PRE-CREATION 
>   src/plasmaview/configview.cpp PRE-CREATION 
>   src/plasmaview/containmentconfigview_p.h PRE-CREATION 
>   src/plasmaview/containmentconfigview_p.cpp PRE-CREATION 
>   src/plasmaview/currentcontainmentactionsmodel_p.h PRE-CREATION 
>   src/plasmaview/currentcontainmentactionsmodel_p.cpp PRE-CREATION 
>   src/plasmaview/includes/PlasmaView/ConfigView PRE-CREATION 
>   src/plasmaview/includes/PlasmaView/ContainmentConfigView PRE-CREATION 
>   src/plasmaview/includes/PlasmaView/ShellPluginLoader PRE-CREATION 
>   src/plasmaview/includes/PlasmaView/View PRE-CREATION 
>   src/plasmaview/shellpackage_p.h PRE-CREATION 
>   src/plasmaview/shellpackage_p.cpp PRE-CREATION 
>   src/plasmaview/shellpluginloader.h PRE-CREATION 
>   src/plasmaview/shellpluginloader.cpp PRE-CREATION 
>   src/plasmaview/view.h PRE-CREATION 
>   src/plasmaview/view.cpp PRE-CREATION 
>   src/shell/CMakeLists.txt 3da019f 
>   src/shell/configview.h 2e8f68f 
>   src/shell/configview.cpp fea5a73 
>   src/shell/containmentconfigview.h 619fa14 
>   src/shell/containmentconfigview.cpp 235a33f 
>   src/shell/currentcontainmentactionsmodel.h db94da1 
>   src/shell/currentcontainmentactionsmodel.cpp c955bef 
>   src/shell/shellcorona.cpp ffdbfe8 
>   src/shell/shellpackage.h 99dc460 
>   src/shell/shellpackage.cpp 74aea5c 
>   src/shell/shellpluginloader.h 1d3dade 
>   src/shell/shellpluginloader.cpp 8b2e1dd 
>   src/shell/view.h 7e6b2d9 
>   src/shell/view.cpp a0c6168 
> 
> Diff: http://git.reviewboard.kde.org/r/112447/diff/
> 
> 
> Testing
> -------
> 
> The code is locate at git at git.kde.org:clones/plasma-framework/tsiapaliwkas/pf5.git .
> 
> how to test it
> 
> * git clone git at git.kde.org:clones/plasma-framework/tsiapaliwkas/pf5.git
> * cd pf5
> * git checkout split7
> * build it and install it
> * use plasma-shell
> 
> I haven't noticed any issues.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130902/82ac1435/attachment-0001.html>