Review Request 113420: port activitybar applet to Plasma2

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113420/#review42409
-----------------------------------------------------------

Ship it!


Looks good to me.

FWIW, when you move files it's best if you make diffs with "git diff --find-copies-harder" that way reviewboard doesn't show that you deleted and created a file. Otherwise I end up commenting on things you didn't change. (


plasma/generic/applets/activitybar/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/113420/#comment30802>

    Long term this probably needs changing so that we only set an implicitWidth and we make the tabBar able to scroll if it's too small.
    Though this isn't a regression and can be fixed another day.



plasma/generic/applets/activitybar/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/113420/#comment30801>

    I don't think we need this on the root item of an applet


- David Edmundson


On Oct. 24, 2013, 3:09 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113420/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2013, 3:09 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> port activitybar applet to plasma2
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/CMakeLists.txt f03f941 
>   plasma/generic/applets/activitybar/CMakeLists.txt 297f1a9 
>   plasma/generic/applets/activitybar/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/activitybar/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/activitybar/package/contents/ui/main.qml a6d5026 
>   plasma/generic/applets/activitybar/package/metadata.desktop b1f2ece 
> 
> Diff: http://git.reviewboard.kde.org/r/113420/diff/
> 
> 
> Testing
> -------
> 
> I don't have any stuffs that can help me to test if it switch activities in Plasma2 or not. It lists my kde4 activities..
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131026/cee40a51/attachment.html>