Review Request 113362: Port Activity dataengine to KF5
Commit Hook
null at kde.org
Mon Oct 21 14:13:33 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113362/#review42096
-----------------------------------------------------------
This review has been submitted with commit 36ac829bd30f06ac145c8caf904aeb40a58f099a by Bhushan Shah to branch master.
- Commit Hook
On Oct. 21, 2013, 1:51 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113362/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 1:51 p.m.)
>
>
> Review request for Plasma, Ivan Čukić and Sebastian Kügler.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Port KActivity DataEngine to KF5
>
> follow ups:
>
> * Activitybar
> * Show activity-manager
> * Activity manger (In progress, Since Declarative widgets are gone, converting wrapper to private import, will be moved to plasma-framework(?))
>
> Commented out setActivityEncrypted() call because not sure if it is gone or will come back..
>
> Also this commit can break build on Jenkins(?)..
>
> I made this adjustments before KActivity cmake thing.
>
>
> Diffs
> -----
>
> CMakeLists.txt 57263a3
> plasma/generic/dataengines/CMakeLists.txt 7826422
> plasma/generic/dataengines/activities/CMakeLists.txt aa3b607
> plasma/generic/dataengines/activities/activityengine.cpp cf73d85
> plasma/generic/dataengines/activities/activityjob.cpp 1a463e2
>
> Diff: http://git.reviewboard.kde.org/r/113362/diff/
>
>
> Testing
> -------
>
> * Compiles
> * Links
> * Installs
> * Loads in plasmaengineexplorer
> * Lists activities and status
>
>
> Thanks,
>
> Bhushan Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131021/d0cf735d/attachment.html>
More information about the Plasma-devel
mailing list