Review Request 113362: Port Activity dataengine to KF5

Bhushan Shah bhush94 at gmail.com
Mon Oct 21 13:51:34 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113362/
-----------------------------------------------------------

(Updated Oct. 21, 2013, 7:21 p.m.)


Review request for Plasma, Ivan Čukić and Sebastian Kügler.


Changes
-------

make it optional and encryption is gone.


Repository: kde-workspace


Description
-------

Port KActivity DataEngine to KF5

follow ups:

* Activitybar
* Show activity-manager
* Activity manger (In progress, Since Declarative widgets are gone, converting wrapper to private import, will be moved to plasma-framework(?))

Commented out setActivityEncrypted() call because not sure if it is gone or will come back..

Also this commit can break build on Jenkins(?).. 

I made this adjustments before KActivity cmake thing.


Diffs (updated)
-----

  CMakeLists.txt 57263a3 
  plasma/generic/dataengines/CMakeLists.txt 7826422 
  plasma/generic/dataengines/activities/CMakeLists.txt aa3b607 
  plasma/generic/dataengines/activities/activityengine.cpp cf73d85 
  plasma/generic/dataengines/activities/activityjob.cpp 1a463e2 

Diff: http://git.reviewboard.kde.org/r/113362/diff/


Testing
-------

* Compiles
* Links
* Installs
* Loads in plasmaengineexplorer
* Lists activities and status


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131021/16e59dfd/attachment.html>


More information about the Plasma-devel mailing list